fix static analyse style

diff --git a/src/feierabend.c b/src/feierabend.c
index 05b7b2f626801be83eb2762e6ef50ca0ca6c3d8b..120608a3752c0f0314fab2f95824d82d4e46e962 100644 (file)
--- a/src/feierabend.c
+++ b/src/feierabend.c
@@ -43,7 +43,7 @@ void _feierabend_free(feierabend* fabend)
        fabend->max_work_end_tm = NULL;
 }
 
-void _print_german_long_date(struct tm* time_info)
+void _print_german_long_date(const struct tm* time_info)
 {
        char* weekday = get_weekday_str(time_info->tm_wday);
 
@@ -70,21 +70,21 @@ void _set_time(time_t* value, struct tm* tm_value, int hour, int minutes)
        *value = mktime(tm_value);
 }
 
-void _print_work_begin(feierabend* fabend)
+void _print_work_begin(const feierabend* fabend)
 {
        printf("%-27s", "Arbeitsbeginn:");
        _print_german_long_date(fabend->begin_tm);
        printf("\n");
 }
 
-void _print_time_now(feierabend* fabend)
+void _print_time_now(const feierabend* fabend)
 {
        printf("%-27s", "Aktuelle Zeit:");
        _print_german_long_date(fabend->now_tm);
        printf("\n");
 }
 
-void _print_work_end(feierabend* fabend)
+void _print_work_end(const feierabend* fabend)
 {
        printf("%s %02d:%02d %-9s", "Arbeitsende",
                SOLL_HOUR,
@@ -94,7 +94,7 @@ void _print_work_end(feierabend* fabend)
        printf("\n");
 }
 
-void _print_max_work_end(feierabend* fabend)
+void _print_max_work_end(const feierabend* fabend)
 {
        printf("%-27s", "Arbeitsende 10:00 Std:");
        _print_german_long_date(fabend->max_work_end_tm);
@@ -179,7 +179,7 @@ void _print_time_to_max_end_worktime(feierabend* fabend)
        timestr = NULL;
 }
 
-int main(int argc, char* argv[])
+int main(int argc, const char* argv[])
 {
        if (argc < 3 || (argc > 3 && argc < 5)) {
                printf("ERROR: %s <begin_hours> <begin_minutes> [<end_hours> <end_minutes>]\n", argv[0]);

diff --git a/src/time_format.c b/src/time_format.c
index d2987838f527ad9396fb17c41f5bbd6363319f0a..4014e0170c5837d112a1e26c492ab72abd5393f0 100644 (file)
--- a/src/time_format.c
+++ b/src/time_format.c
@@ -175,7 +175,7 @@ int get_day_from_str(const char* date)
        char* str_first_pos = str;
 
        str = strtok(str, "-");
-       str = strtok(NULL, "-");
+       strtok(NULL, "-");
        str = strtok(NULL, "-");
        value = atoi(str);
 

diff --git a/src/xml.c b/src/xml.c
index 2281a15f9d0cad6e32a1ece8abe605ff03fd8b1b..25efe7f0049c71259443f30bf3ea5cad8019d78c 100644 (file)
--- a/src/xml.c
+++ b/src/xml.c
@@ -393,11 +393,10 @@ void readLastSaldo(memFile* mem, char* value)
 
 void copyNodeAttributes(xmlTextReaderPtr xmlreader, xmlTextWriterPtr xmlwriter)
 {
-       xmlNodePtr xmlnode = NULL;
        int attrCount = xmlTextReaderAttributeCount(xmlreader);
        for (int i = 0; i < attrCount; i++) {
                xmlTextReaderMoveToNextAttribute(xmlreader);
-               xmlnode = xmlTextReaderCurrentNode(xmlreader);
+               xmlNodePtr xmlnode = xmlTextReaderCurrentNode(xmlreader);
                xmlTextWriterWriteAttribute(xmlwriter, xmlnode->name, xmlnode->children[0].content);
        }
 }
@@ -540,7 +539,6 @@ void merge(const char* dir)
                }
                xmlTextReaderClose(xmlreader);
                xmlFreeTextReader(xmlreader);
-               xmlreader = NULL;
        }
 
        xmlTextWriterEndElement(xmlwriter);