fix builder script shellcheck issues

diff --git a/builder/builder b/builder/builder
index 7304a7d75107fbce99cdc064a667bba5d536cd28..26f034f4acdacaefeba3a332f63e1ec89c0cc0ee 100755 (executable)
--- a/builder/builder
+++ b/builder/builder
@@ -5,9 +5,8 @@ create_containerfile()
        local distro="$1"
        local distro_postfix="$2"
 
-       cat builder/Containerfile.template \
-               | sed "s/\$distro/$distro/" \
-               > build/Containerfile-$distro_postfix \
+       sed "s/\$distro/$distro/" builder/Containerfile.template \
+               > "build/Containerfile-$distro_postfix" \
                || return $?
 }
 
@@ -16,8 +15,8 @@ build_container_image()
        local distro_postfix="$1"
 
        podman build \
-               --tag simple-backup-builder:$distro_postfix \
-               --file build/Containerfile-$distro_postfix \
+               --tag "simple-backup-builder:$distro_postfix" \
+               --file "build/Containerfile-$distro_postfix" \
                || return $?
 }
 
@@ -29,7 +28,7 @@ run_builder_container()
                --tty \
                --rm \
                --volume .:/src \
-               simple-backup-builder:$distro_postfix \
+               "simple-backup-builder:$distro_postfix" \
                || return $?
 }
 

diff --git a/builder/run b/builder/run
index 3a019e03913ec74051464c63c5cbfb87192144b4..6408addf0d017989f097c28e41c500ffc872b31c 100644 (file)
--- a/builder/run
+++ b/builder/run
@@ -2,36 +2,39 @@
 
 get_source_date()
 {
+       export SOURCE_DATE_EPOCH=
        umask 0022 || return $?
        cd /src || return $?
-       export SOURCE_DATE_EPOCH=$(git log --max-count=1 --pretty="%ct")
+       SOURCE_DATE_EPOCH=$(git log --max-count=1 --pretty="%ct")
        export EXTRA_VERSION="-$ID-$VERSION_CODENAME"
 }
 
 create_package_checksum()
 {
+       local package=
        cd /app/build/build || return $?
-       local package=$(find . -maxdepth 1 -name '*.deb')
-       lintian --fail-on error,warning,pedantic $package || return $?
-       sha256sum *.deb > $package.sha256 || return $?
-       cat $package.sha256 || return $?
+       package=$(find . -maxdepth 1 -name '*.deb')
+       lintian --fail-on error,warning,pedantic "$package" || return $?
+       sha256sum ./*.deb > "$package.sha256" || return $?
+       cat "$package.sha256" || return $?
 }
 
 reproducible_package_checksum_check()
 {
+       local package=
        cd /app/reproducible-build/build || return $?
-       local package=$(find . -maxdepth 1 -name '*.deb')
-       cp /src/build/$package.sha256 . || return $?
-       cat $package.sha256 || return $?
-       sha256sum -c $package.sha256 || return $?
+       package=$(find . -maxdepth 1 -name '*.deb')
+       cp "/src/build/$package.sha256" . || return $?
+       cat "$package.sha256" || return $?
+       sha256sum -c "$package.sha256" || return $?
 }
 
 build_package()
 {
        cd /app || return $?
        rsync --recursive --exclude=build* /src/ /app/build || return $?
-       cd /app/build
-       make --jobs=$(nproc) package || return $?
+       cd /app/build || return $?
+       make --jobs="$(nproc)" package || return $?
 }
 
 copy_package()
@@ -47,7 +50,7 @@ build_reproducible_package()
        rsync --recursive --exclude=build* /src/ /app/reproducible-build \
                || return $?
        cd /app/reproducible-build || return $?
-       make --jobs=$(nproc) package || return $?
+       make --jobs="$(nproc)" package || return $?
 }
 
 main()