fix static analyse warnings

diff --git a/src/kds_s2000w_client.c b/src/kds_s2000w_client.c
index 3440145df711ff21aa04aeeb1be895c64d03ab59..12b37861b9299621e12996d101c15c7895c542c1 100644 (file)
--- a/src/kds_s2000w_client.c
+++ b/src/kds_s2000w_client.c
@@ -176,7 +176,6 @@ void kds_s2000w_client_response_free(response* resp)
        free(resp->data);
        resp->data = NULL;
        free(resp);
-       resp = NULL;
 }
 
 uint8_t kds_s2000w_client_open_session(response* resp)

diff --git a/src/kds_s2000w_config.c b/src/kds_s2000w_config.c
index f3fc756ee859c34f441aa2e9b4165ecf80b89a61..f27f72677a51207cb6d483ab006d2ed58e6e0b21 100644 (file)
--- a/src/kds_s2000w_config.c
+++ b/src/kds_s2000w_config.c
@@ -119,5 +119,4 @@ void kds_s2000w_config_free(program_config* config)
        free(config->username);
        config->username = NULL;
        free(config);
-       config = NULL;
 }
\ No newline at end of file

diff --git a/src/kds_s2000w_debug.c b/src/kds_s2000w_debug.c
index 6531b2b21926bd1318f3f9b0f5b3e9dddaf93436..d723902c1e0fede52fcd4188cf51238b3684114d 100644 (file)
--- a/src/kds_s2000w_debug.c
+++ b/src/kds_s2000w_debug.c
@@ -75,11 +75,11 @@ void kds_s2000w_debug_printf_int(uint8_t level, const char* msg, uint32_t value)
                return;
 
        if (level < STDOUT_LEVEL) {
-               fprintf(stderr, "%s: %s: %i\n", _kds_s2000w_debug_string(level) , msg, value);
+               fprintf(stderr, "%s: %s: %u\n", _kds_s2000w_debug_string(level) , msg, value);
                return;
        }
 
-       fprintf(stdout, "%s: %s: %i\n", _kds_s2000w_debug_string(level), msg, value);
+       fprintf(stdout, "%s: %s: %u\n", _kds_s2000w_debug_string(level), msg, value);
 }
 
 void kds_s2000w_debug_printf_long(uint8_t level, const char* msg, uint64_t value)
@@ -88,11 +88,11 @@ void kds_s2000w_debug_printf_long(uint8_t level, const char* msg, uint64_t value
                return;
 
        if (level < STDOUT_LEVEL) {
-               fprintf(stderr, "%s: %s: %li\n", _kds_s2000w_debug_string(level) , msg, value);
+               fprintf(stderr, "%s: %s: %lu\n", _kds_s2000w_debug_string(level) , msg, value);
                return;
        }
 
-       fprintf(stdout, "%s: %s: %li\n", _kds_s2000w_debug_string(level), msg, value);
+       fprintf(stdout, "%s: %s: %lu\n", _kds_s2000w_debug_string(level), msg, value);
 }
 
 void kds_s2000w_debug_messure_memory_usage(uint8_t level)

diff --git a/src/kds_s2000w_handler.c b/src/kds_s2000w_handler.c
index 67897a84df780cb1e0211e1dc0eb19f8427d835f..429e513fe4e6df9c2021d5ec940358d68a68ca5b 100644 (file)
--- a/src/kds_s2000w_handler.c
+++ b/src/kds_s2000w_handler.c
@@ -122,7 +122,6 @@ void kds_s2000w_handler_free(handler* h)
        free(h->coord);
        h->coord = NULL;
        free(h);
-       h = NULL;
 }
 
 void kds_s2000w_handler_reset(handler* h)
@@ -210,17 +209,15 @@ void kds_s2000w_handler_close(handler* h)
 {
        kds_s2000w_debug_printf(ALL, "kds_s2000w_handler_close");
 
-       json_object_put(h->current_scanner_config);
-       h->current_scanner_config = NULL;
-
        if (h == NULL)
                return;
 
+       json_object_put(h->current_scanner_config);
+       h->current_scanner_config = NULL;
        kds_s2000w_client_close_session(h->sessionid);
        kds_s2000w_client_free();
        h->sessionid = 0;
        kds_s2000w_handler_free(h);
-       h = NULL;
 }
 
 void kds_s2000w_handler_recreate_session(handler* h)

diff --git a/src/kds_s2000w_option_descriptors.c b/src/kds_s2000w_option_descriptors.c
index 3b948eb2252f63a22cc304fadced34cbb2b38627..e305573b8f12e291903f4ddd7b307f9e24f19a16 100644 (file)
--- a/src/kds_s2000w_option_descriptors.c
+++ b/src/kds_s2000w_option_descriptors.c
@@ -40,7 +40,6 @@ void _kds_s2000w_option_descriptor_descriptor_free(option_descriptor* descriptor
        free(descriptor->descriptor);
        descriptor->descriptor = NULL;
        free(descriptor);
-       descriptor = NULL;
 }
 
 SANE_Status _kds_s2000w_option_descriptor_validate()