From: Bastian Dehn <hhaalo@arcor.de>
Date: Sat, 22 Jun 2024 06:56:38 +0000 (+0200)
Subject: fix max string length for value
X-Git-Tag: 1.2.0^2~16^2~31
X-Git-Url: https://gitweb.hhaalo.de/?a=commitdiff_plain;h=b0d407503801bd32ff55d82db0b57bfe7d6012d3;p=feierabend.git

fix max string length for value
---

diff --git a/src/feierabendxml.c b/src/feierabendxml.c
index 01ecdd3..b22914d 100644
--- a/src/feierabendxml.c
+++ b/src/feierabendxml.c
@@ -1,9 +1,12 @@
 #include <stdio.h>
+#include <string.h>
 #include <libxml/encoding.h>
 #include <libxml/xmlwriter.h>
 #include "time_format.h"
 #include "feierabend.h"
 
+#define MAX_STRING_LENGTH 36
+
 void init_feierabend(feierabend* fabend)
 {
 	fabend->now = malloc(sizeof(time_t));
@@ -38,7 +41,7 @@ int main(int argc, char* argv[])
 	init_feierabend(fabend);
 	xmlChar* xmlElemName = xmlCharStrdup("zeitkonto");
 	xmlChar* xmlElemContent = NULL;
-	char* value = malloc(sizeof(char) * 11);
+	char* value = malloc(sizeof(char) * MAX_STRING_LENGTH);
 
 	xmlTextWriterPtr xmlWriter = xmlNewTextWriterFilename("/dev/stdout", 0);
 	xmlTextWriterSetIndent(xmlWriter, 8);
@@ -67,6 +70,7 @@ int main(int argc, char* argv[])
 	xmlElemContent = xmlCharStrdup(value);
 	xmlElemName = xmlCharStrdup("wochentag");
 	xmlTextWriterWriteAttribute(xmlWriter, xmlElemName, xmlElemContent);
+	memset(value, 0, MAX_STRING_LENGTH);
 	free(xmlElemName);
 	xmlElemName = NULL;
 	free(xmlElemContent);
@@ -78,6 +82,7 @@ int main(int argc, char* argv[])
 		fabend->now_tm->tm_mday);
 	xmlElemContent = xmlCharStrdup(value);
 	xmlTextWriterWriteAttribute(xmlWriter, xmlElemName, xmlElemContent);
+	memset(value, 0, MAX_STRING_LENGTH);
 	free(xmlElemName);
 	xmlElemName = NULL;
 	free(xmlElemContent);