From: Bastian Dehn <hhaalo@arcor.de>
Date: Fri, 6 Jan 2017 20:58:56 +0000 (+0100)
Subject: change: flactomp3 eyeD3 command with eval
X-Git-Tag: v1.0.0^2~121
X-Git-Url: https://gitweb.hhaalo.de/?a=commitdiff_plain;h=d7d49da5a3d0f5550675efe1bc6d054400e52be5;p=albentohandy.git

change: flactomp3 eyeD3 command with eval

change: build eyeD3 command before execute everything
---

diff --git a/flactomp3v2.sh b/flactomp3v2.sh
index d674464..d47fe9d 100755
--- a/flactomp3v2.sh
+++ b/flactomp3v2.sh
@@ -27,34 +27,24 @@ RTP=$(metaflac "$INPUTFILE" --show-tag=REPLAYGAIN_TRACK_PEAK | sed s/.*=//g)
 RAG=$(metaflac "$INPUTFILE" --show-tag=REPLAYGAIN_ALBUM_GAIN | sed s/.*=//g)
 RAP=$(metaflac "$INPUTFILE" --show-tag=REPLAYGAIN_ALBUM_PEAK | sed s/.*=//g)
 
-# stream flac into the lame encoder
-flac -s -c -d "$INPUTFILE" | lame --silent -b $BITRATE -m $MODE --noreplaygain - "$OUTPUTFILE"
-
 # ID3v2.3 tagging with cover and without cover
+eyed3Command="eyeD3 -v2 --to-v2.3 \
+-a \"$ARTIST\" -t \"$TITLE\" -A \"$ALBUM\" -G \"${GENRE:-12}\" \
+-n \"${TRACKNUMBER:-0}\" -Y \"$DATE\" \
+--set-user-text-frame=\"REPLAYGAIN_REFERENCE_LOUDNESS:$RRL\" \
+--set-user-text-frame=\"REPLAYGAIN_TRACK_GAIN:$RTG\" \
+--set-user-text-frame=\"REPLAYGAIN_TRACK_PEAK:$RTP\" \
+--set-user-text-frame=\"REPLAYGAIN_ALBUM_GAIN:$RAG\" \
+--set-user-text-frame=\"REPLAYGAIN_ALBUM_PEAK:$RAP\""
 if [ -f ${INPUTFILE%/*}/cover.jpg ]
 then
-	eyeD3 -v2 --to-v2.3 \
--a "$ARTIST" -t "$TITLE" -A "$ALBUM" -G "${GENRE:-12}" \
--n "${TRACKNUMBER:-0}" -Y "$DATE" \
---set-user-text-frame="REPLAYGAIN_REFERENCE_LOUDNESS:$RRL" \
---set-user-text-frame="REPLAYGAIN_TRACK_GAIN:$RTG" \
---set-user-text-frame="REPLAYGAIN_TRACK_PEAK:$RTP" \
---set-user-text-frame="REPLAYGAIN_ALBUM_GAIN:$RAG" \
---set-user-text-frame="REPLAYGAIN_ALBUM_PEAK:$RAP" \
---add-image ${INPUTFILE%/*}/cover.jpg:FRONT_COVER \
---no-tagging-time-frame \
-$OUTPUTFILE > /dev/null 2>&1
-else
-	eyeD3 -v2 --to-v2.3 \
--a "$ARTIST" -t "$TITLE" -A "$ALBUM" -G "${GENRE:-12}" \
--n "${TRACKNUMBER:-0}" -Y "$DATE" \
---set-user-text-frame="REPLAYGAIN_REFERENCE_LOUDNESS:$RRL" \
---set-user-text-frame="REPLAYGAIN_TRACK_GAIN:$RTG" \
---set-user-text-frame="REPLAYGAIN_TRACK_PEAK:$RTP" \
---set-user-text-frame="REPLAYGAIN_ALBUM_GAIN:$RAG" \
---set-user-text-frame="REPLAYGAIN_ALBUM_PEAK:$RAP" \
---no-tagging-time-frame \
-$OUTPUTFILE > /dev/null 2>&1
+	eyed3Command+=" --add-image \"${INPUTFILE%/*}/cover.jpg\":FRONT_COVER"
 fi
+eyed3Command+=" --no-tagging-time-frame \
+\"$OUTPUTFILE\" > /dev/null 2>&1"
+
+# stream flac into the lame encoder
+flac -s -c -d "$INPUTFILE" | lame --silent -b $BITRATE -m $MODE --noreplaygain - "$OUTPUTFILE"
+eval $eyed3Command
 
 exit 0