From 1886e3754d28d382dd723ce8af1249925c0e5288 Mon Sep 17 00:00:00 2001
From: Bastian Dehn <hhaalo@arcor.de>
Date: Sat, 11 Oct 2025 19:02:33 +0200
Subject: [PATCH] fix static analyse style

---
 src/feierabend.c  | 12 ++++++------
 src/time_format.c |  2 +-
 src/xml.c         |  4 +---
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/feierabend.c b/src/feierabend.c
index 05b7b2f..120608a 100644
--- a/src/feierabend.c
+++ b/src/feierabend.c
@@ -43,7 +43,7 @@ void _feierabend_free(feierabend* fabend)
 	fabend->max_work_end_tm = NULL;
 }
 
-void _print_german_long_date(struct tm* time_info)
+void _print_german_long_date(const struct tm* time_info)
 {
 	char* weekday = get_weekday_str(time_info->tm_wday);
 
@@ -70,21 +70,21 @@ void _set_time(time_t* value, struct tm* tm_value, int hour, int minutes)
 	*value = mktime(tm_value);
 }
 
-void _print_work_begin(feierabend* fabend)
+void _print_work_begin(const feierabend* fabend)
 {
 	printf("%-27s", "Arbeitsbeginn:");
 	_print_german_long_date(fabend->begin_tm);
 	printf("\n");
 }
 
-void _print_time_now(feierabend* fabend)
+void _print_time_now(const feierabend* fabend)
 {
 	printf("%-27s", "Aktuelle Zeit:");
 	_print_german_long_date(fabend->now_tm);
 	printf("\n");
 }
 
-void _print_work_end(feierabend* fabend)
+void _print_work_end(const feierabend* fabend)
 {
 	printf("%s %02d:%02d %-9s", "Arbeitsende",
 		SOLL_HOUR,
@@ -94,7 +94,7 @@ void _print_work_end(feierabend* fabend)
 	printf("\n");
 }
 
-void _print_max_work_end(feierabend* fabend)
+void _print_max_work_end(const feierabend* fabend)
 {
 	printf("%-27s", "Arbeitsende 10:00 Std:");
 	_print_german_long_date(fabend->max_work_end_tm);
@@ -179,7 +179,7 @@ void _print_time_to_max_end_worktime(feierabend* fabend)
 	timestr = NULL;
 }
 
-int main(int argc, char* argv[])
+int main(int argc, const char* argv[])
 {
 	if (argc < 3 || (argc > 3 && argc < 5)) {
 		printf("ERROR: %s <begin_hours> <begin_minutes> [<end_hours> <end_minutes>]\n", argv[0]);
diff --git a/src/time_format.c b/src/time_format.c
index d298783..4014e01 100644
--- a/src/time_format.c
+++ b/src/time_format.c
@@ -175,7 +175,7 @@ int get_day_from_str(const char* date)
 	char* str_first_pos = str;
 
 	str = strtok(str, "-");
-	str = strtok(NULL, "-");
+	strtok(NULL, "-");
 	str = strtok(NULL, "-");
 	value = atoi(str);
 
diff --git a/src/xml.c b/src/xml.c
index 2281a15..25efe7f 100644
--- a/src/xml.c
+++ b/src/xml.c
@@ -393,11 +393,10 @@ void readLastSaldo(memFile* mem, char* value)
 
 void copyNodeAttributes(xmlTextReaderPtr xmlreader, xmlTextWriterPtr xmlwriter)
 {
-	xmlNodePtr xmlnode = NULL;
 	int attrCount = xmlTextReaderAttributeCount(xmlreader);
 	for (int i = 0; i < attrCount; i++) {
 		xmlTextReaderMoveToNextAttribute(xmlreader);
-		xmlnode = xmlTextReaderCurrentNode(xmlreader);
+		xmlNodePtr xmlnode = xmlTextReaderCurrentNode(xmlreader);
 		xmlTextWriterWriteAttribute(xmlwriter, xmlnode->name, xmlnode->children[0].content);
 	}
 }
@@ -540,7 +539,6 @@ void merge(const char* dir)
 		}
 		xmlTextReaderClose(xmlreader);
 		xmlFreeTextReader(xmlreader);
-		xmlreader = NULL;
 	}
 
 	xmlTextWriterEndElement(xmlwriter);
-- 
2.47.3