From 9429890edc831dfc4a263ea2254ec6f2166d91f8 Mon Sep 17 00:00:00 2001
From: Bastian Dehn <hhaalo@arcor.de>
Date: Sun, 6 Sep 2026 09:23:55 +0200
Subject: [PATCH] change write vorbis picture metadata once

---
 libs/vorbis.sh | 41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)

diff --git a/libs/vorbis.sh b/libs/vorbis.sh
index 20b540c..3da8636 100644
--- a/libs/vorbis.sh
+++ b/libs/vorbis.sh
@@ -56,12 +56,11 @@ flac_to_vorbis()
 write_hex_to_file()
 {
 	local number="$1"
-	local output="$2"
 	local hex_number=
 	hex_number=$(printf "%08x" "$number")
 
 	for i in {0..6..2}; do
-		printf "%b" "\x${hex_number:$i:2}" >> "$output"
+		printf "%b" "\x${hex_number:$i:2}"
 	done
 }
 
@@ -73,24 +72,26 @@ cover_to_metadata()
 	filesize=$(wc --bytes "$input")
 	filesize=${filesize/ */}
 
-	# picture typ (jpg)
-	write_hex_to_file "3" "$output"
-	# mime type (image/jpeg)
-	write_hex_to_file "10" "$output"
-	printf "%s" "image/jpeg" >> "$output"
-	# description length (zero)
-	write_hex_to_file "0" "$output"
-	# width (zero)
-	write_hex_to_file "0" "$output"
-	# heigth (zero)
-	write_hex_to_file "0" "$output"
-	# color depth (zero)
-	write_hex_to_file "0" "$output"
-	# color count (zero)
-	write_hex_to_file "0" "$output"
-	# file size
-	write_hex_to_file "$filesize" "$output"
-	cat "$input" >> "$output"
+	{
+		# picture typ (jpg)
+		write_hex_to_file "3"
+		# mime type (image/jpeg)
+		write_hex_to_file "10"
+		printf "%s" "image/jpeg"
+		# description length (zero)
+		write_hex_to_file "0"
+		# width (zero)
+		write_hex_to_file "0"
+		# heigth (zero)
+		write_hex_to_file "0"
+		# color depth (zero)
+		write_hex_to_file "0"
+		# color count (zero)
+		write_hex_to_file "0"
+		# file size
+		write_hex_to_file "$filesize"
+		cat "$input"
+	} > "$output"
 }
 
 convert_flac_to_ogg()
-- 
2.47.3