From 95609a68eecb182dc4b2d12183aa5a5cada6256b Mon Sep 17 00:00:00 2001
From: Bastian Dehn <hhaalo@arcor.de>
Date: Sat, 24 May 2025 18:57:58 +0200
Subject: [PATCH] add correct input parameter checks

---
 backup | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/backup b/backup
index 5afa0db..a719e81 100755
--- a/backup
+++ b/backup
@@ -252,22 +252,22 @@ main()
 	backup_name=$(cat config.yaml | yq -r '.backup_name')
 	backup_count=$(cat config.yaml | yq -r '.backup_count')
 
-	[ "$backup_path" != "null" ] \
-		|| errlog "missing backup path" \
+	[ -n "$backup_path" ] && [ "$backup_path" != "null" ] \
+		|| errlog "missing backup_path in config.yaml" \
+		|| return $?
+	[ -d "$backup_path" ] \
+		|| errlog "directory $backup_path not exists" \
 		|| return $?
 	echo "ℹ️  INFO: backup path $backup_path"
-	[ "$backup_name" != "null" ] \
-		|| errlog "missing backup name" \
+	[ -n "$backup_name" ] && [ "$backup_name" != "null" ] \
+		|| errlog "missing backup_name in config.yaml" \
 		|| return $?
 	echo "ℹ️  INFO: backup name $backup_name"
-	[ "$backup_count" != "null" ] \
-		|| errlog "missing backup count" \
+	[ -n "$backup_count" ] && [ "$backup_count" != "null" ] \
+		|| errlog "missing backup_count in config.yaml" \
 		|| return $?
 	echo "ℹ️  INFO: backup count $backup_count"
 
-	[ -d "$backup_path" ] \
-		|| errlog "directory $backup_path not exists" \
-		|| return $?
 
 	local backup_dir=$(get_backup_dir \
 		"$backup_path" \
-- 
2.47.3