From da8e66be6f161f578f41ea416a65be1c79f3b7dd Mon Sep 17 00:00:00 2001 From: Bastian Dehn Date: Sat, 11 Oct 2025 16:05:03 +0200 Subject: [PATCH] fix static analyse warnings --- src/kds_s2000w_client.c | 1 - src/kds_s2000w_config.c | 1 - src/kds_s2000w_debug.c | 8 ++++---- src/kds_s2000w_handler.c | 7 ++----- src/kds_s2000w_option_descriptors.c | 1 - 5 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/kds_s2000w_client.c b/src/kds_s2000w_client.c index 3440145..12b3786 100644 --- a/src/kds_s2000w_client.c +++ b/src/kds_s2000w_client.c @@ -176,7 +176,6 @@ void kds_s2000w_client_response_free(response* resp) free(resp->data); resp->data = NULL; free(resp); - resp = NULL; } uint8_t kds_s2000w_client_open_session(response* resp) diff --git a/src/kds_s2000w_config.c b/src/kds_s2000w_config.c index f3fc756..f27f726 100644 --- a/src/kds_s2000w_config.c +++ b/src/kds_s2000w_config.c @@ -119,5 +119,4 @@ void kds_s2000w_config_free(program_config* config) free(config->username); config->username = NULL; free(config); - config = NULL; } \ No newline at end of file diff --git a/src/kds_s2000w_debug.c b/src/kds_s2000w_debug.c index 6531b2b..d723902 100644 --- a/src/kds_s2000w_debug.c +++ b/src/kds_s2000w_debug.c @@ -75,11 +75,11 @@ void kds_s2000w_debug_printf_int(uint8_t level, const char* msg, uint32_t value) return; if (level < STDOUT_LEVEL) { - fprintf(stderr, "%s: %s: %i\n", _kds_s2000w_debug_string(level) , msg, value); + fprintf(stderr, "%s: %s: %u\n", _kds_s2000w_debug_string(level) , msg, value); return; } - fprintf(stdout, "%s: %s: %i\n", _kds_s2000w_debug_string(level), msg, value); + fprintf(stdout, "%s: %s: %u\n", _kds_s2000w_debug_string(level), msg, value); } void kds_s2000w_debug_printf_long(uint8_t level, const char* msg, uint64_t value) @@ -88,11 +88,11 @@ void kds_s2000w_debug_printf_long(uint8_t level, const char* msg, uint64_t value return; if (level < STDOUT_LEVEL) { - fprintf(stderr, "%s: %s: %li\n", _kds_s2000w_debug_string(level) , msg, value); + fprintf(stderr, "%s: %s: %lu\n", _kds_s2000w_debug_string(level) , msg, value); return; } - fprintf(stdout, "%s: %s: %li\n", _kds_s2000w_debug_string(level), msg, value); + fprintf(stdout, "%s: %s: %lu\n", _kds_s2000w_debug_string(level), msg, value); } void kds_s2000w_debug_messure_memory_usage(uint8_t level) diff --git a/src/kds_s2000w_handler.c b/src/kds_s2000w_handler.c index 67897a8..429e513 100644 --- a/src/kds_s2000w_handler.c +++ b/src/kds_s2000w_handler.c @@ -122,7 +122,6 @@ void kds_s2000w_handler_free(handler* h) free(h->coord); h->coord = NULL; free(h); - h = NULL; } void kds_s2000w_handler_reset(handler* h) @@ -210,17 +209,15 @@ void kds_s2000w_handler_close(handler* h) { kds_s2000w_debug_printf(ALL, "kds_s2000w_handler_close"); - json_object_put(h->current_scanner_config); - h->current_scanner_config = NULL; - if (h == NULL) return; + json_object_put(h->current_scanner_config); + h->current_scanner_config = NULL; kds_s2000w_client_close_session(h->sessionid); kds_s2000w_client_free(); h->sessionid = 0; kds_s2000w_handler_free(h); - h = NULL; } void kds_s2000w_handler_recreate_session(handler* h) diff --git a/src/kds_s2000w_option_descriptors.c b/src/kds_s2000w_option_descriptors.c index 3b948eb..e305573 100644 --- a/src/kds_s2000w_option_descriptors.c +++ b/src/kds_s2000w_option_descriptors.c @@ -40,7 +40,6 @@ void _kds_s2000w_option_descriptor_descriptor_free(option_descriptor* descriptor free(descriptor->descriptor); descriptor->descriptor = NULL; free(descriptor); - descriptor = NULL; } SANE_Status _kds_s2000w_option_descriptor_validate() -- 2.47.3